Skip to content

Update plugin.xml and plugin-specific services to actual IntelliJ API #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 9, 2023

Conversation

Vassiliy-Kudryashov
Copy link
Member

Description

There were issues with uploading UnitTestBot plugin 2023.10 to the marketplace:

Upload Not Possible
1 Error
Your plugin file contains 1 error. To upload your plugin to Marketplace, please fix these errors and try again.

Service preloading is deprecated in the <com.intellij.projectService> element. Consider removing the 'preload' attribute and migrating to listeners, see https://plugins.jetbrains.com/docs/intellij/plugin-listeners.html
7 Warnings
We also recommend that you fix the 7 warnings flagged in your plugin file, as this will drastically improve the quality of your plugin.

Fixing warnings is optional and will not prevent you from uploading your plugin to Marketplace.

Plugin ID specified in plugin.xml should not contain 'intellij'
Configuration file 'withJava.xml' for optional dependency 'com.intellij.modules.java' is invalid: Invalid plugin descriptor 'withJava.xml': Unable to read plugin descriptor
Configuration file 'withKotlin.xml' for optional dependency 'org.jetbrains.kotlin' is invalid: Invalid plugin descriptor 'withKotlin.xml': Unable to read plugin descriptor
Configuration file 'withPython.xml' for optional dependency 'com.intellij.modules.python' is invalid: Invalid plugin descriptor 'withPython.xml': Unable to read plugin descriptor
Configuration file 'withGo.xml' for optional dependency 'org.jetbrains.plugins.go' is invalid: Invalid plugin descriptor 'withGo.xml': Unable to read plugin descriptor
Configuration file 'withAndroid.xml' for optional dependency 'org.jetbrains.android' is invalid: Invalid plugin descriptor 'withAndroid.xml': Unable to read plugin descriptor
Configuration file 'withIdeaMaven.xml' for optional dependency 'org.jetbrains.idea.maven' is invalid: Invalid plugin descriptor 'withIdeaMaven.xml': Unable to read plugin descriptor

Specified error was fixed, we use annotation in code instead of projectService tag.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@Vassiliy-Kudryashov Vassiliy-Kudryashov added comp-ide Issue is related to IDE support ctg-bug-fix PR is fixing a bug labels Oct 9, 2023
@alisevych alisevych self-requested a review October 9, 2023 12:45
Copy link
Member

@alisevych alisevych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke test from branch passed:

@Vassiliy-Kudryashov Vassiliy-Kudryashov merged commit e3f5516 into main Oct 9, 2023
@Vassiliy-Kudryashov Vassiliy-Kudryashov deleted the unit-test-bot/rc2023.10 branch October 9, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-ide Issue is related to IDE support ctg-bug-fix PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants