Avoid spying collection-like types with @Spy if it may mislead @InjectMocks behaviour #2642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tepa46
added
comp-codegen
tepa46
changed the title
EgorkaKulikov
changed the title
IlyaMuravjov
reviewed
Oct 4, 2023
...mework/src/main/kotlin/org/utbot/framework/codegen/tree/fieldmanager/CgSpiedFieldsManager.kt
Outdated
Show resolved
Hide resolved
...mework/src/main/kotlin/org/utbot/framework/codegen/tree/fieldmanager/CgSpiedFieldsManager.kt
Outdated
Show resolved
Hide resolved
...mework/src/main/kotlin/org/utbot/framework/codegen/tree/fieldmanager/CgSpiedFieldsManager.kt
Outdated
Show resolved
Hide resolved
...mework/src/main/kotlin/org/utbot/framework/codegen/tree/fieldmanager/CgSpiedFieldsManager.kt
Outdated
Show resolved
Hide resolved
EgorkaKulikov
changed the title
IlyaMuravjov
reviewed
Oct 4, 2023
...mework/src/main/kotlin/org/utbot/framework/codegen/tree/fieldmanager/CgSpiedFieldsManager.kt
Outdated
Show resolved
Hide resolved
...mework/src/main/kotlin/org/utbot/framework/codegen/tree/fieldmanager/CgSpiedFieldsManager.kt
Outdated
Show resolved
Hide resolved
IlyaMuravjov
approved these changes
Oct 4, 2023
...mework/src/main/kotlin/org/utbot/framework/codegen/tree/fieldmanager/CgSpiedFieldsManager.kt
Show resolved
Hide resolved
EgorkaKulikov
approved these changes
Oct 4, 2023
alisevych
deleted the
kirill/fix-bug-with-Spying-different-types-of-thisInstance-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we have models of different types implementing Collection or Map, we should not construct fields of these models with
@Spyannotation but just usesetFieldfor it. Otherwise it will cause problems with@InjectMocksin Mockito because injection by type is used and in generated tests bothList<A>andList<B>are represented asList listSpy.One of the possible scenarios to reproduce the bug we fix here is to generate tests for
Ownerclass inspring-petclinicproject with 100% fuzzing. Before this fix, several different spies were created but injected not as we expect after that.Self-check list