Skip to content

Support for both Cookie libraries for different versions of Spring #2606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

tepa46
Copy link
Collaborator

@tepa46 tepa46 commented Sep 18, 2023

Description

Fixes #2542

Added support for jakarta.servlet.http.Cookie which is used in newer versions of Spring.

How to test

Manual tests

Tested on the spring-petclinic project. (Spring Boot 3.1.3 with jakarta.servlet.http.Cookie)
Tested on the spring-boot-testing project. (Spring Boot 2.7.3 with javax.servlet.http.Cookie)

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@tepa46 tepa46 added comp-codegen Issue is related to code generator ctg-bug-fix PR is fixing a bug comp-spring Issue is related to Spring projects support labels Sep 18, 2023
@tepa46 tepa46 force-pushed the kirill/supporting-Cookies-libraries branch from f23735f to 84bbb1f Compare September 19, 2023 22:22
@EgorkaKulikov EgorkaKulikov merged commit bc1edcd into main Sep 20, 2023
@EgorkaKulikov EgorkaKulikov deleted the kirill/supporting-Cookies-libraries branch September 20, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-codegen Issue is related to code generator comp-spring Issue is related to Spring projects support ctg-bug-fix PR is fixing a bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ClassNotFoundException: javax.servlet.http.Cookie when generating controller tests
2 participants