Don't collect constants from every assignment statement #2558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2527
The bug happens because constants are incorrectly collected on pre-process phase. An if-statement bytecode for longs and doubles has follow steps:
cmp
operationThere's no check that an if-statement has
cmp
operation in an assignment statement, therefore it accepts any method call as well.How to test
Manual tests
Example from the issue should generate 2 tests.
Self-check list