Call entityManager.flush()
on every entityManager
usage and dynamically remove failing UtStatementCallModel
s
#2550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UtStatementCallModel
s that have been observed to throw an exception fromstateBefore
then try to rerun the invocation, that process is repeated until either value construction phase succeeds or limit of 5 reruns is reached.entityManager.flush()
on everyentityManager
usage (in codegen only).ClassNotFoundException: javax.servlet.http.Cookie
when generating controller tests #2542 by reverting Add support for @CookieValue annotation #2519.How to test
Manual tests
Failing test from issue should not generate (in the example from the issue, test that saves valid entity to the database is still minimized out due to it being possible to cover all branches of
OwnerController.findOwner()
without saving anything to the database, to get tests with actual saves to database, the lineif (owner == null) throw new NullPointerException("owner");
can be added toOwnerController.findOwner()
).Self-check list