Skip to content

Call entityManager.flush() on every entityManager usage and dynamically remove failing UtStatementCallModels #2550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 25, 2023

Conversation

IlyaMuravjov
Copy link
Collaborator

@IlyaMuravjov IlyaMuravjov commented Aug 24, 2023

Description

How to test

Manual tests

Failing test from issue should not generate (in the example from the issue, test that saves valid entity to the database is still minimized out due to it being possible to cover all branches of OwnerController.findOwner() without saving anything to the database, to get tests with actual saves to database, the line if (owner == null) throw new NullPointerException("owner"); can be added to OwnerController.findOwner()).

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@IlyaMuravjov IlyaMuravjov added ctg-enhancement New feature, improvement or change request comp-codegen Issue is related to code generator comp-instrumented-process Issue is related to Instrumented process comp-spring Issue is related to Spring projects support labels Aug 24, 2023
@IlyaMuravjov IlyaMuravjov marked this pull request as ready for review August 24, 2023 10:24
@EgorkaKulikov EgorkaKulikov merged commit f9c9534 into main Aug 25, 2023
@EgorkaKulikov EgorkaKulikov deleted the ilya_m/safe_call_models_and_flush branch August 25, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-codegen Issue is related to code generator comp-instrumented-process Issue is related to Instrumented process comp-spring Issue is related to Spring projects support ctg-enhancement New feature, improvement or change request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClassNotFoundException: javax.servlet.http.Cookie when generating controller tests Invalid entity is generated and then searched with Controller
2 participants