Skip to content

Let engine process utContext use Platform ClassLoader #2512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

IlyaMuravjov
Copy link
Collaborator

Description

Fixes #2479

Makes utContext.classLoader in engine process use ClassLoader.getSystemClassLoader().parent as a parent class loader, so classes like javax.sql.DataSource (from jrt:/java.sql) can be loaded by platform ClassLoader.

How to test

Manual tests

  • Generate tests for methods that accept and return javax.sql.DataSource
  • Generate tests for guava 32.0 (utbot uses guava 30.0 at the moment)

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@IlyaMuravjov IlyaMuravjov added comp-infrastructure Infrastructure issues ctg-bug-fix PR is fixing a bug labels Aug 15, 2023
@EgorkaKulikov EgorkaKulikov merged commit 9311c26 into main Aug 17, 2023
@EgorkaKulikov EgorkaKulikov deleted the ilya_m/utcontext_platform_classloader branch August 17, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-infrastructure Infrastructure issues ctg-bug-fix PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants