Skip to content

Avoid collecting useless models in SpringTestClassModelBuilder #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

EgorkaKulikov
Copy link
Collaborator

@EgorkaKulikov EgorkaKulikov commented Aug 1, 2023

Description

When we implemented models traverser in February, we collected some of them just "to have". Now we realised that it is useless.

How to test

Automated tests

Standard Spring tests pipeline

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@EgorkaKulikov EgorkaKulikov added comp-codegen Issue is related to code generator ctg-refactoring Issue related to refactoring process comp-spring Issue is related to Spring projects support labels Aug 1, 2023
@EgorkaKulikov EgorkaKulikov enabled auto-merge (squash) August 1, 2023 13:41
@EgorkaKulikov EgorkaKulikov merged commit 792bc2d into main Aug 1, 2023
@EgorkaKulikov EgorkaKulikov deleted the egor/remove_useless_models_collecting branch August 1, 2023 13:43
@alisevych alisevych added this to the Spring Phase 4 milestone Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-codegen Issue is related to code generator comp-spring Issue is related to Spring projects support ctg-refactoring Issue related to refactoring process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants