Skip to content

Fix summaries generation for anonymous classes #2459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

Markoutte
Copy link
Collaborator

Description

Fixes #2458

Anonymous classes have no canonical name. Summaries fails to find those names and no test can be generated because of this. I've changed the call from canonicalName to name that (I think) is the same in the most situations.

How to test

Manual tests

Run ContestEstimator from the origin issue. It should generate test as expected.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@Markoutte Markoutte added comp-summaries Something related to the method names, code comments and display names generation comp-fuzzing Issue is related to the fuzzing comp-contest-estimator Issue is related to contest estimator ctg-bug-fix PR is fixing a bug labels Jul 31, 2023
@Markoutte Markoutte requested a review from EgorkaKulikov July 31, 2023 05:21
@EgorkaKulikov EgorkaKulikov merged commit 6a61824 into main Jul 31, 2023
@EgorkaKulikov EgorkaKulikov deleted the pelevin/2458-fix-summaries-canonical-name branch July 31, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-contest-estimator Issue is related to contest estimator comp-fuzzing Issue is related to the fuzzing comp-summaries Something related to the method names, code comments and display names generation ctg-bug-fix PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.IllegalStateException: ClassId com.google.common.collect.TreeMultiset$1 does not have canonical name
2 participants