-
Notifications
You must be signed in to change notification settings - Fork 46
Add bytecode transformation for if statement with call of String methods #2446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocal variables of the method
Markoutte
reviewed
Aug 1, 2023
|
||
override fun build(writer: ClassWriter): BytecodeTransformer = BytecodeTransformer(writer) | ||
}) | ||
if (UtSettings.useBytecodeTransformation) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instrumentation has no access to UtSettings. Because of this it fails to create any test
Markoutte
approved these changes
Aug 2, 2023
@@ -19,6 +20,7 @@ private val logger = getLogger<DynamicClassTransformer>() | |||
class DynamicClassTransformer : ClassFileTransformer { | |||
lateinit var transformer: ClassFileTransformer | |||
|
|||
var useBytecodeTransformation by Delegates.notNull<Boolean>() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use lateinit var
here instead of delegate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp-instrumented-process
Issue is related to Instrumented process
ctg-enhancement
New feature, improvement or change request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bytecode transformation of the if statement with call of the
String.equals
,String.startsWith
orString.endsWith
method with a constant string into a sequence of comparisons of each char of the string with each char of the constant string.For example, this code
at the bytecode level will be transformed to this
How to test
Automated tests
Run
org.utbot.examples.TestBytecodeTransformation
inutbot-instrumentation-tests
moduleManual tests
Self-check list
Check off the item if the statement is true. Hint: [x] is a marked item.
Please do not delete the list or its items.