-
Notifications
You must be signed in to change notification settings - Fork 46
Fix DummySpringBootIntegrationTestClass
annotations
#2415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorkaKulikov
approved these changes
Jul 14, 2023
EgorkaKulikov
approved these changes
Jul 16, 2023
@IlyaMuravjov |
Here's the stack trace I was getting when incorrect annotation were used:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp-codegen
Issue is related to code generator
comp-instrumented-process
Issue is related to Instrumented process
comp-spring
Issue is related to Spring projects support
ctg-bug-fix
PR is fixing a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DummySpringBootIntegrationTestClassAutoconfigTestDB
was missing@BootstrapWith(SpringBootTestContextBootstrapper::class)
annotation, because its parent class wasDummySpringIntegrationTestClass
instead ofDummySpringBootIntegrationTestClass
.DummySpringBootIntegrationTestClass
didn't have@SpringBootTest
annotation, even though according to@SpringBootTest
javadoc it configures test context in more ways than just@BootstrapWith(SpringBootTestContextBootstrapper::class)
.Also, this PR performs same changes in generated code annotations.
How to test
Manual tests
Generate integration tests for
Medical-Web-App
project (while having all necessary docker containers running as described in the project README), there should be no exception stack trace rendered incontextLoads()
test.Self-check list