Refactor to reduce coupling of base UtBot implementation with Spring-specific features #2411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaMuravjov
added
ctg-refactoring
IlyaMuravjov
force-pushed
the
ilya_m/refactor_spring_app_context
branch
from
a7aaf80 to
6569628
Compare
IlyaMuravjov
changed the title
ApplicationContext into multiple interfaces
IlyaMuravjov
force-pushed
the
ilya_m/refactor_spring_app_context
branch
2 times, most recently
from
19cb36d to
2874151
Compare
Closed
6 tasks
sergeypospelov
requested changes
Jul 19, 2023
| } | ||
| } | ||
|
|
||
| class SimpleUtExecutionInstrumentation( |
There was a problem hiding this comment.
Let's extract it to a separate file
| @@ -117,4 +117,8 @@ class InvokeInstrumentation : Instrumentation<Result<*>> { | |||
| protectionDomain: ProtectionDomain, | |||
| classfileBuffer: ByteArray | |||
| ) = null | |||
|
|
|||
| class Factory : Instrumentation.Factory<Result<*>, InvokeInstrumentation> { | |||
| @@ -57,4 +57,8 @@ class ExecutionTraceInstrumentation : Instrumentation<Trace> { | |||
| classByteCode | |||
| } | |||
| } | |||
|
|
|||
| class Factory : Instrumentation.Factory<Trace, ExecutionTraceInstrumentation> { | |||
| @@ -94,6 +94,10 @@ object CoverageInstrumentation : Instrumentation<Result<*>> { | |||
|
|
|||
| return instrumenter.classByteCode | |||
| } | |||
|
|
|||
| class Factory : Instrumentation.Factory<Result<*>, CoverageInstrumentation> { | |||
| @@ -89,6 +89,10 @@ class InvokeWithStaticsInstrumentation : Instrumentation<Result<*>> { | |||
| .forEach { it.withAccessibility { it.set(null, savedFields[it.name]) } } | |||
| } | |||
| } | |||
|
|
|||
| class Factory : Instrumentation.Factory<Result<*>, InvokeWithStaticsInstrumentation> { | |||
IlyaMuravjov
force-pushed
the
ilya_m/refactor_spring_app_context
branch
from
396a4fb to
186a0fb
Compare
EgorkaKulikov
approved these changes
Jul 20, 2023
…NullPointerException` into one method
…lementors` with `beanDefinitions.isNotEmpty()`
…pplicationContext` type
…arams in functions and constructors
IlyaMuravjov
force-pushed
the
ilya_m/refactor_spring_app_context
branch
from
f9a6a20 to
dbf4da7
Compare
sergeypospelov
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2358, #2226
How to test
Regression tests (this pull request should not change UtBot semantics at all)
Self-check list