Improved communication contracts in utbot-spring-analyzer #2164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofurihafe
added
ctg-enhancement
sofurihafe
force-pushed
the
andrey-t/spring_get_rid_of_classpath
branch
from
bab65b1 to
4dac71c
Compare
|
Failing CI shows that manual tests are nevertheless relevant... |
sofurihafe
force-pushed
the
andrey-t/spring_get_rid_of_classpath
branch
from
4dac71c to
3b11eb1
Compare
sofurihafe
force-pushed
the
andrey-t/spring_get_rid_of_classpath
branch
from
3b11eb1 to
de620a0
Compare
IlyaMuravjov
requested changes
Apr 21, 2023
Comment on lines
-101
to
106
| val extendedClasspath = listOf(requiredSpringAnalyzerJarPath) + classpathItems | ||
|
|
||
| val requiredSpringAnalyzerJarPath = findRequiredSpringAnalyzerJarPath() | ||
| val rdProcess = startUtProcessWithRdServer(lifetime) { port -> | ||
| classpathArgs = listOf( | ||
| "-cp", | ||
| "\"${extendedClasspath.joinToString(File.pathSeparator)}\"", | ||
| "\"$requiredSpringAnalyzerJarPath\"", | ||
| "org.utbot.spring.process.SpringAnalyzerProcessMainKt" | ||
| ) |
There was a problem hiding this comment.
We still want to continue using classpathItems here, so spring-analyzer process is started with user's classpath. Meaning that we want to pass user's classpath all the way up to here via UtTestsDialogProcessor -> EngineProcess -EngineProcessModel -> EngineProcessMain, but we don't want it to go any further via SpringAnalyzerProcess -> SpringAnalyzerProcessModel -> SpringAnalyzerProcessMain.
Since this pull request is only changing contracts, it should not change the behavior, so you can't change command line arguments that are used to start the process.
|
Replaced with #2174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves communication in utbot-spring-analyzer by getting rid of unused arguments and changing types.
Fixes #2160
How to test
Automated tests
Manual tests
Not relevant.