Skip to content

Make loading Spring bean classes even more safe #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

IlyaMuravjov
Copy link
Collaborator

Description

Wraps class loading and ClassId instantiation to be even more safe for Spring beans

How to test

Manual tests

Can be tested on a big project with many different bean definitions or @EnableAutoConfiguration annotation on a selected @Configuration in a Spring Boot application. Symbolic engine should not fail and beans that failed to load should be logged in rdEngineProcessLogs (e.g. org.springframework.boot.autoconfigure.jdbc.metadata.DataSourcePoolMetadataProvidersConfiguration$HikariPoolDataSourceMetadataProviderConfiguration$$Lambda$560/0x00000008011446e8)

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@IlyaMuravjov IlyaMuravjov added ctg-enhancement New feature, improvement or change request comp-symbolic-engine Issue is related to the symbolic execution engine comp-spring Issue is related to Spring projects support labels Apr 17, 2023
@EgorkaKulikov EgorkaKulikov enabled auto-merge (squash) April 17, 2023 20:37
@EgorkaKulikov EgorkaKulikov merged commit 43a9760 into main Apr 17, 2023
@EgorkaKulikov EgorkaKulikov deleted the ilya_m/safer_bean_class_loading branch April 17, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-spring Issue is related to Spring projects support comp-symbolic-engine Issue is related to the symbolic execution engine ctg-enhancement New feature, improvement or change request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants