Skip to content

Use more safe approach to analyze Spring xml configs #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

EgorkaKulikov
Copy link
Collaborator

Description

Fixes # (2123)
Some additional details are provided in documentation in code

How to test

Manual tests

  • Scenario from the issue
  • Standard regression of configs detection

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@EgorkaKulikov EgorkaKulikov added comp-ui Improvements of plugin UI appearence and functionality ctg-bug-fix PR is fixing a bug labels Apr 11, 2023
@EgorkaKulikov EgorkaKulikov requested a review from mmvpm April 11, 2023 08:07
@EgorkaKulikov EgorkaKulikov merged commit 6c76c65 into main Apr 11, 2023
@EgorkaKulikov EgorkaKulikov deleted the egor/safety_parsing_xml_configs branch April 11, 2023 08:36
@alisevych alisevych added this to the Spring Phase 1 milestone Apr 12, 2023
@alisevych alisevych added the comp-spring Issue is related to Spring projects support label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-spring Issue is related to Spring projects support comp-ui Improvements of plugin UI appearence and functionality ctg-bug-fix PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempt to call Socket.connect during parsing Spring XML configuration file
3 participants