Skip to content

Improve the appearance of paths in Spring Config Selection ComboBox #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 10, 2023

Conversation

tepa46
Copy link
Collaborator

@tepa46 tepa46 commented Apr 4, 2023

Description

Fixes #2079

Now the paths to the Spring Config Selection Combobox have become shorter.

Added functions that shorten paths.
How is this done: parent directories are appended to the file name until the path becomes unique

Example:

["config.web.WebConfig", "config.web2.WebConfig", "config.web.AnotherConfig"] ->["web.WebConfig", "web2.WebConfig", "AnotherConfig"]

image

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@tepa46 tepa46 added ctg-enhancement New feature, improvement or change request comp-ui Improvements of plugin UI appearence and functionality comp-spring Issue is related to Spring projects support labels Apr 4, 2023
@tepa46 tepa46 requested a review from EgorkaKulikov April 4, 2023 23:01
@EgorkaKulikov EgorkaKulikov changed the title Improving the appearance of paths in Spring Config Selection ComboBox Improve the appearance of paths in Spring Config Selection ComboBox Apr 10, 2023
@EgorkaKulikov EgorkaKulikov force-pushed the kirill/spring-config-ui branch from e6a439f to 70c67dd Compare April 10, 2023 06:49
@EgorkaKulikov EgorkaKulikov linked an issue Apr 10, 2023 that may be closed by this pull request
@EgorkaKulikov EgorkaKulikov enabled auto-merge (squash) April 10, 2023 06:57
@EgorkaKulikov EgorkaKulikov disabled auto-merge April 10, 2023 07:07
@EgorkaKulikov EgorkaKulikov merged commit 67bd15d into main Apr 10, 2023
@EgorkaKulikov EgorkaKulikov deleted the kirill/spring-config-ui branch April 10, 2023 07:27
@alisevych alisevych added this to the Spring Phase 1 milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-spring Issue is related to Spring projects support comp-ui Improvements of plugin UI appearence and functionality ctg-enhancement New feature, improvement or change request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve rendering Spring configuration name on UI
3 participants