Skip to content

Set MockStrategy default value properly in Spring projects #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

EgorkaKulikov
Copy link
Collaborator

@EgorkaKulikov EgorkaKulikov commented Apr 4, 2023

Description

MockStrategy default strategy is other packages.

In Spring applications, the behavior is different:

  • In No configuration mode, default value is other classes
  • in other modes, default and suggested only value is other classes

How to test

Automated tests

New test ensureDefaultStrategyIsOtherClassesInSpringApplication introduced.

Manual tests

UI manual regression.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@EgorkaKulikov EgorkaKulikov added comp-ui Improvements of plugin UI appearence and functionality ctg-bug-fix PR is fixing a bug comp-spring Issue is related to Spring projects support labels Apr 4, 2023
@Vassiliy-Kudryashov Vassiliy-Kudryashov enabled auto-merge (squash) April 4, 2023 12:56
@Vassiliy-Kudryashov Vassiliy-Kudryashov merged commit db0c21a into main Apr 4, 2023
@Vassiliy-Kudryashov Vassiliy-Kudryashov deleted the egor/ui_mockstrategies_defaultitem branch April 4, 2023 13:49
@alisevych alisevych added this to the Spring Phase 1 milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-spring Issue is related to Spring projects support comp-ui Improvements of plugin UI appearence and functionality ctg-bug-fix PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants