Skip to content

Open "sun.net.util", "sun.nio.fs" and "java.nio.file" for reflection #2061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2023
Merged

Open "sun.net.util", "sun.nio.fs" and "java.nio.file" for reflection #2061

merged 3 commits into from
Mar 28, 2023

Conversation

Vassiliy-Kudryashov
Copy link
Member

Description

Open more packages for reflection (some generated tests need it under Java 17+)

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@Vassiliy-Kudryashov Vassiliy-Kudryashov added comp-codegen Issue is related to code generator ctg-bug-fix PR is fixing a bug labels Mar 28, 2023
@Vassiliy-Kudryashov Vassiliy-Kudryashov enabled auto-merge (squash) March 28, 2023 14:09
@alisevych alisevych added this to the 2023.3 Release milestone Mar 28, 2023
@Vassiliy-Kudryashov Vassiliy-Kudryashov removed the request for review from Domonion March 28, 2023 14:45
@Vassiliy-Kudryashov Vassiliy-Kudryashov merged commit 270ec87 into main Mar 28, 2023
@Vassiliy-Kudryashov Vassiliy-Kudryashov deleted the Vassiliy-Kudryashov/open_packages_for_reflection branch March 28, 2023 15:07
Vassiliy-Kudryashov added a commit that referenced this pull request Mar 28, 2023
@Vassiliy-Kudryashov
Open "sun.net.util", "sun.nio.fs" and "java.nio.file" for reflection (#…
088c5e4 
…2061)
@alisevych alisevych mentioned this pull request Mar 28, 2023
Open
denis-fokin added a commit that referenced this pull request Mar 29, 2023
@denis-fokin
Revert "Open "sun.net.util", "sun.nio.fs" and "java.nio.file" for ref…
043a89e 
…lection (#2061)"

This reverts commit 088c5e4.
@alisevych alisevych removed this from the 2023.3 Release milestone Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaelmBleidd CaelmBleidd CaelmBleidd approved these changes

Assignees
No one assigned
Labels
comp-codegen Issue is related to code generator ctg-bug-fix PR is fixing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vassiliy-Kudryashov @CaelmBleidd @alisevych