Skip to content

Enlarge ModelId in codegen with testSetId #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2023
Merged

Enlarge ModelId in codegen with testSetId #2059

merged 1 commit into from
Mar 28, 2023

Conversation

EgorkaKulikov
Copy link
Collaborator

Description

We would like to have the unique identifier of the UtModel in terms of code generator.
It has already been introduced and called ModelId.
However, id and executableId is not enough: we should also keep testSetId in it.

How to test

Standalone testing is not required, just as a part of Spring 1st phase.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@EgorkaKulikov EgorkaKulikov added ctg-enhancement New feature, improvement or change request comp-codegen Issue is related to code generator comp-spring Issue is related to Spring projects support labels Mar 28, 2023
@EgorkaKulikov EgorkaKulikov force-pushed the egor/spring_injectmocks_bug branch from 4722b43 to 4a6913b Compare March 28, 2023 14:03
@EgorkaKulikov EgorkaKulikov enabled auto-merge (squash) March 28, 2023 14:31
sofurihafe
sofurihafe approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@sofurihafe sofurihafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@EgorkaKulikov EgorkaKulikov merged commit 096fda1 into main Mar 28, 2023
@EgorkaKulikov EgorkaKulikov deleted the egor/spring_injectmocks_bug branch March 28, 2023 14:40
@alisevych alisevych added this to the Spring Phase 1 milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sofurihafe sofurihafe sofurihafe approved these changes

Assignees
No one assigned
Labels
comp-codegen Issue is related to code generator comp-spring Issue is related to Spring projects support ctg-enhancement New feature, improvement or change request
Projects
None yet
Milestone
Spring Phase 1
Development

Successfully merging this pull request may close these issues.
3 participants
@EgorkaKulikov @sofurihafe @alisevych