Skip to content

Make TypeReplacementApproach be sealed class, so configFqn is stored #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2023
Merged

Make TypeReplacementApproach be sealed class, so configFqn is stored #2032

merged 1 commit into from
Mar 24, 2023

Conversation

IlyaMuravjov
Copy link
Collaborator

@IlyaMuravjov IlyaMuravjov commented Mar 24, 2023 •
edited by EgorkaKulikov
Loading

Description

Simple refactoring, needed in other branches

How to test

Just a part of String support internals, should not be tested as a standalone app.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@IlyaMuravjov IlyaMuravjov added ctg-refactoring Issue related to refactoring process comp-spring Issue is related to Spring projects support labels Mar 24, 2023
@EgorkaKulikov EgorkaKulikov enabled auto-merge (squash) March 24, 2023 09:13
@EgorkaKulikov EgorkaKulikov merged commit 5ab14c8 into main Mar 24, 2023
@EgorkaKulikov EgorkaKulikov deleted the ilya_m/refactor_type_replacement_approach branch March 24, 2023 10:05
@alisevych alisevych added this to the Spring Phase 1 milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgorkaKulikov EgorkaKulikov EgorkaKulikov approved these changes

Assignees
No one assigned
Labels
comp-spring Issue is related to Spring projects support ctg-refactoring Issue related to refactoring process
Projects
None yet
Milestone
Spring Phase 1
Development

Successfully merging this pull request may close these issues.
3 participants
@IlyaMuravjov @EgorkaKulikov @alisevych