Go. Bug fixes #2031
Merged
Go. Bug fixes #2031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egiptipavel
added
ctg-bug-fix
Markoutte
approved these changes
Mar 24, 2023
| throw TimeoutException("Timeout exceeded: Worker didn't finish") | ||
| val processOutput = InputStreamReader(process.inputStream).readText() | ||
| throw TimeoutException( | ||
| StringBuilder() |
There was a problem hiding this comment.
You can use buildString { } to do the same
| @@ -112,7 +112,13 @@ object GoTestCasesGenerator { | |||
| val processHasExited = process.waitFor(endOfWorkerExecutionTimeout, TimeUnit.MILLISECONDS) | |||
| if (!processHasExited) { | |||
| process.destroy() | |||
| throw TimeoutException("Timeout exceeded: Worker didn't finish") | |||
| val processOutput = InputStreamReader(process.inputStream).readText() | |||
There was a problem hiding this comment.
Output can be huge. Do this read really necessary?
| @@ -132,7 +138,13 @@ object GoTestCasesGenerator { | |||
| val processHasExited = process.waitFor(endOfWorkerExecutionTimeout, TimeUnit.MILLISECONDS) | |||
| if (!processHasExited) { | |||
| process.destroy() | |||
| logger.error { "Timeout exceeded: Worker didn't finish" } | |||
| val processOutput = InputStreamReader(process.inputStream).readText() | |||
There was a problem hiding this comment.
Same comments as before
Markoutte
approved these changes
Mar 27, 2023
denis-fokin
pushed a commit
that referenced
this pull request
Mar 27, 2023
* Fix bug with nested unexported structs * Delete timeout for worker execution * Add logging when worker doesn't finish * Add sample file * Add message about failed parsing of source code analysis result * Change StringBuilder on buildString * Add message about failed starting the worker (cherry picked from commit 86a20d5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How to test
Manual tests
Test on
utbot-go/go-samples/simple/samples.goandutbot-go/go-samples/simple/supported_types.gofiles.Self-check list
Check off the item if the statement is true. Hint: [x] is a marked item.
Please do not delete the list or its items.