Skip to content

Use detected project type in Codegen #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2023
Merged

Use detected project type in Codegen #1985

merged 2 commits into from
Mar 20, 2023

Conversation

EgorkaKulikov
Copy link
Collaborator

Description

Before this PR, we had isSpringClass flag setted directly in CgContext to hack Codegen for Spring generation.
Currently, we define if project is Spring or not in UtTestsDialogProcessor and use obtained value in Codegen.

How to test

Does not require standalone testing.
Just verify that for project without Spring there are no awful regressions.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@EgorkaKulikov EgorkaKulikov added ctg-enhancement New feature, improvement or change request comp-codegen Issue is related to code generator comp-spring Issue is related to Spring projects support labels Mar 20, 2023
IlyaMuravjov
IlyaMuravjov reviewed Mar 20, 2023
View reviewed changes
utbot-intellij/src/main/kotlin/org/utbot/intellij/plugin/ui/GenerateTestsDialogWindow.kt Outdated
Comment on lines 530 to 529
model.applicationType = ApplicationType.PURE_JVM
model.projectType = ProjectType.SPRING
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has the default project type been changed to ProjectType.SPRING?

@EgorkaKulikov EgorkaKulikov mentioned this pull request Mar 20, 2023
Closed
@EgorkaKulikov EgorkaKulikov force-pushed the egor/pass_spring_properties_codegen branch from 069c27d to 58f3683 Compare March 20, 2023 13:35
@EgorkaKulikov EgorkaKulikov force-pushed the egor/pass_spring_properties_codegen branch from 58f3683 to 4223184 Compare March 20, 2023 13:41
@EgorkaKulikov EgorkaKulikov enabled auto-merge (squash) March 20, 2023 14:00
@EgorkaKulikov EgorkaKulikov merged commit 290c095 into main Mar 20, 2023
@EgorkaKulikov EgorkaKulikov deleted the egor/pass_spring_properties_codegen branch March 20, 2023 14:18
@alisevych alisevych added this to the Spring Phase 1 milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamarinvs19 tamarinvs19 tamarinvs19 approved these changes

@IlyaMuravjov IlyaMuravjov IlyaMuravjov approved these changes

Assignees
No one assigned
Labels
comp-codegen Issue is related to code generator comp-spring Issue is related to Spring projects support ctg-enhancement New feature, improvement or change request
Projects
None yet
Milestone
Spring Phase 1
Development

Successfully merging this pull request may close these issues.
4 participants
@EgorkaKulikov @tamarinvs19 @IlyaMuravjov @alisevych