Skip to content

Some pre-integration refactoring of utbot-spring-analyzer #1970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2023
Merged

Some pre-integration refactoring of utbot-spring-analyzer #1970

merged 2 commits into from
Mar 17, 2023

Conversation

EgorkaKulikov
Copy link
Collaborator

Description

utbot-spring-analyzer cleaned up with little fixes in:

  • resource folder path definition
  • resource-marker.txt file name (russian letter)
  • package naming

How to test

Should not be tested standalone, just as a part of Spring support 1st phase.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@EgorkaKulikov EgorkaKulikov added ctg-refactoring Issue related to refactoring process comp-spring Issue is related to Spring projects support labels Mar 17, 2023
IlyaMuravjov
IlyaMuravjov approved these changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@IlyaMuravjov IlyaMuravjov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EgorkaKulikov EgorkaKulikov enabled auto-merge (squash) March 17, 2023 14:58
@EgorkaKulikov EgorkaKulikov merged commit b04990f into main Mar 17, 2023
@EgorkaKulikov EgorkaKulikov deleted the egor/spring_analyzer_cleanup branch March 17, 2023 15:19
@alisevych alisevych added this to the Spring Phase 1 milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IlyaMuravjov IlyaMuravjov IlyaMuravjov approved these changes

Assignees
No one assigned
Labels
comp-spring Issue is related to Spring projects support ctg-refactoring Issue related to refactoring process
Projects
None yet
Milestone
Spring Phase 1
Development

Successfully merging this pull request may close these issues.
3 participants
@EgorkaKulikov @IlyaMuravjov @alisevych