Skip to content

Rider plugin bugfixes #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2023
Merged

Rider plugin bugfixes #1967

merged 1 commit into from
Mar 20, 2023

Conversation

mxprshn
Copy link
Collaborator

@mxprshn mxprshn commented Mar 16, 2023 •
edited
Loading

  • Check for installed .NET SDKs instead of runtimes, as they are necessary for publish
  • Remove logging from popup notification method
  • Fix RPC timeout for test generation
  • Use -a flag instead of -r in Publisher because incorrect RIDs appeared

@mxprshn mxprshn added comp-rider-plugin Rider C# plugin relates issues ctg-bug-fix PR is fixing a bug labels Mar 16, 2023
@mxprshn mxprshn requested review from Domonion and MchKosticyn March 16, 2023 20:07
@mxprshn mxprshn force-pushed the rider-plugin-sdk-check-fix branch 4 times, most recently from 1488d52 to a62127e Compare March 17, 2023 18:43
@mxprshn mxprshn changed the title Rider plugin: fix SDK check Rider plugin bugfixes Mar 17, 2023
Domonion
Domonion approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@Domonion Domonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discuss

utbot-rider/src/dotnet/UtBot/UtBot/UnitTestBuilder.cs Outdated
@@ -257,8 +255,10 @@ private TypeDescriptor ToTypeDescriptor(IType typ, IMethod declMethod, ITypeElem
var projectCsprojPath = project.ProjectFileLocation.FullPath;
var args = new GenerateArguments(assemblyPath, projectCsprojPath, solutionFilePath, descriptors,
timeout, testProjectFramework.FrameworkMoniker.Name);
var rpcTimeout = TimeSpan.FromHours(1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 1 hour?

@mxprshn mxprshn force-pushed the rider-plugin-sdk-check-fix branch from a62127e to 59f26a3 Compare March 20, 2023 09:58
@mxprshn mxprshn force-pushed the rider-plugin-sdk-check-fix branch from 59f26a3 to cd04b5c Compare March 20, 2023 09:59
Domonion
Domonion approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@Domonion Domonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Domonion Domonion merged commit 21422b8 into UnitTestBot:main Mar 20, 2023
Domonion pushed a commit that referenced this pull request Mar 28, 2023
@mxprshn @Domonion
Rider plugin bugfixes (#1967)
b26f23b 
[fix] Sdk check fix, timeout fix, publish arch fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Domonion Domonion Domonion approved these changes

@MchKosticyn MchKosticyn Awaiting requested review from MchKosticyn

Assignees
No one assigned
Labels
comp-rider-plugin Rider C# plugin relates issues ctg-bug-fix PR is fixing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxprshn @Domonion