Skip to content

Fix the way of looking for native libraries #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

CaelmBleidd
Copy link
Member

@CaelmBleidd CaelmBleidd commented Mar 15, 2023

Change paths to native Z3 libraries

Description

Changed paths leading to Z3 libraries. Depending on a platform, we should look either in lib/x64 library or in lib/arm. This is bug fix that should make its behaviour consistent with KSMT.

How to test

Automated tests

Run automatic tests on different platforms.

Manual tests

You can run any test of runIde task with test generation on any project. If it generates anything using a solver -- it works.

Self-check list

Please do not delete the list or its items.

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@CaelmBleidd CaelmBleidd added comp-infrastructure Infrastructure issues ctg-bug-fix PR is fixing a bug labels Mar 15, 2023
Copy link
Member

@Damtev Damtev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaelmBleidd CaelmBleidd enabled auto-merge (squash) March 15, 2023 18:01
@CaelmBleidd CaelmBleidd merged commit 18fcbdd into main Mar 15, 2023
@CaelmBleidd CaelmBleidd deleted the caelmbleidd/finding_native_libraries_fix branch March 15, 2023 18:30
denis-fokin pushed a commit that referenced this pull request Mar 16, 2023
@alisevych alisevych added this to the 2023.03 Release milestone Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-infrastructure Infrastructure issues ctg-bug-fix PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants