Skip to content

Refactor name and module management in python code generation and fuzzing #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 16, 2023

Conversation

tamarinvs19
Copy link
Collaborator

Description

Module and name of python object have been separated to different fields in PythonClassId. Now we have two constructors:

  • from module and object name (without module prefix)
  • from full name (it expect that object name doesn`t contain dots)

Text type representations have been replaced to constants from util file.

Also fixed problem with objects which have same id and name but different fields in state after / state before.

Fixes #1850

How to test

Manual tests

See #1850

Self-check list

Check off the item if the statement is true. Hint: [x] is a marked item.

Please do not delete the list or its items.

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@tamarinvs19 tamarinvs19 added comp-codegen Issue is related to code generator ctg-refactoring Issue related to refactoring process comp-fuzzing Issue is related to the fuzzing lang-python Issue is related to python support ctg-bug-fix PR is fixing a bug labels Mar 15, 2023
@tamarinvs19 tamarinvs19 requested a review from tochilinak March 15, 2023 14:23
@tamarinvs19 tamarinvs19 self-assigned this Mar 15, 2023
@tamarinvs19 tamarinvs19 merged commit c3feb6a into main Mar 16, 2023
@tamarinvs19 tamarinvs19 deleted the tamarinvs19/python-fix-inner-classes branch March 16, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-codegen Issue is related to code generator comp-fuzzing Issue is related to the fuzzing ctg-bug-fix PR is fixing a bug ctg-refactoring Issue related to refactoring process lang-python Issue is related to python support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are not generated for classes that have inner classes
2 participants