Skip to content

Support regions without comments, e.g. mocking utils region for Spring #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2023
Merged

Support regions without comments, e.g. mocking utils region for Spring #1926

merged 2 commits into from
Mar 13, 2023

Conversation

IlyaMuravjov
Copy link
Collaborator

Description

Fixes #1920

Besides, fixing #1920 refactor CgKotlinRenderer, so it renders @JvmStatic in renderMethodSignature(CgParameterizedTestDataProviderMethod) and not in visit(CgStaticsRegion) the same way CgJavaRenderer does it. It avoids duplication of CgAbstractRenderer.CgRegion<*>.render() code in CgKotlinRenderer.visit(CgStaticsRegion).

How to test

Standard regression checks on regression tests.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@IlyaMuravjov IlyaMuravjov added ctg-enhancement New feature, improvement or change request comp-codegen Issue is related to code generator comp-spring Issue is related to Spring projects support labels Mar 10, 2023
@EgorkaKulikov EgorkaKulikov merged commit 69fb323 into main Mar 13, 2023
@EgorkaKulikov EgorkaKulikov deleted the ilya-m/regions_without_comments branch March 13, 2023 09:12
CaelmBleidd pushed a commit that referenced this pull request Mar 14, 2023
@IlyaMuravjov @CaelmBleidd
Support regions without comments, e.g. mocking utils region for Spring …
5ccb38e 
…#1920 (#1926)
tamarinvs19 pushed a commit that referenced this pull request Mar 15, 2023
@IlyaMuravjov @tamarinvs19
Support regions without comments, e.g. mocking utils region for Spring …
b5b94a3 
…#1920 (#1926)
@alisevych alisevych added this to the Spring Phase 1 milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgorkaKulikov EgorkaKulikov EgorkaKulikov approved these changes

Assignees
No one assigned
Labels
comp-codegen Issue is related to code generator comp-spring Issue is related to Spring projects support ctg-enhancement New feature, improvement or change request
Projects
None yet
Milestone
Spring Phase 1
Development

Successfully merging this pull request may close these issues.

Render Spring setUp and tearDown without regions
3 participants
@IlyaMuravjov @EgorkaKulikov @alisevych