Skip to content

Go. Hide timeout per execution from dialog #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Go. Hide timeout per execution from dialog #1910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions ...o/src/main/kotlin/org/utbot/intellij/plugin/language/go/ui/GenerateGoTestsDialogWindow.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package org.utbot.intellij.plugin.language.go.ui

import com.goide.psi.GoFunctionOrMethodDeclaration
import com.goide.refactor.ui.GoDeclarationInfo
import com.intellij.openapi.components.service
import com.intellij.openapi.ui.DialogPanel
import com.intellij.openapi.ui.DialogWrapper
import com.intellij.openapi.ui.ValidationInfo
Expand All @@ -12,13 +13,11 @@ import com.intellij.util.ui.JBUI
import com.intellij.util.ui.UIUtil
import org.utbot.go.logic.GoUtTestsGenerationConfig
import org.utbot.intellij.plugin.language.go.models.GenerateGoTestsModel
import org.utbot.intellij.plugin.settings.Settings
import java.text.ParseException
import java.util.concurrent.TimeUnit
import javax.swing.JComponent

private const val MINIMUM_EACH_EXECUTION_TIMEOUT_MILLIS = 1
private const val EACH_EXECUTION_TIMEOUT_MILLIS_SPINNER_STEP = 10

private const val MINIMUM_ALL_EXECUTION_TIMEOUT_SECONDS = 1
private const val ALL_EXECUTION_TIMEOUT_SECONDS_SPINNER_STEP = 10

Expand All @@ -38,13 +37,6 @@ class GenerateGoTestsDialogWindow(val model: GenerateGoTestsModel) : DialogWrapp
Int.MAX_VALUE,
ALL_EXECUTION_TIMEOUT_SECONDS_SPINNER_STEP
)
private val eachFunctionExecutionTimeoutMillisSpinner =
JBIntSpinner(
GoUtTestsGenerationConfig.DEFAULT_EACH_EXECUTION_TIMEOUT_MILLIS.toInt(),
MINIMUM_EACH_EXECUTION_TIMEOUT_MILLIS,
Int.MAX_VALUE,
EACH_EXECUTION_TIMEOUT_MILLIS_SPINNER_STEP
)

private lateinit var panel: DialogPanel

Expand All @@ -65,10 +57,6 @@ class GenerateGoTestsDialogWindow(val model: GenerateGoTestsModel) : DialogWrapp
component(allFunctionExecutionTimeoutSecondsSpinner)
component(JBLabel("seconds"))
}
row("Timeout for each function execution:") {
component(eachFunctionExecutionTimeoutMillisSpinner)
component(JBLabel("ms"))
}
}
updateFunctionsOrMethodsTable()
return panel
Expand All @@ -77,11 +65,13 @@ class GenerateGoTestsDialogWindow(val model: GenerateGoTestsModel) : DialogWrapp
override fun doOKAction() {
model.selectedFunctions = targetFunctionsTable.selectedMemberInfos.fromInfos()
try {
eachFunctionExecutionTimeoutMillisSpinner.commitEdit()
allFunctionExecutionTimeoutSecondsSpinner.commitEdit()
} catch (_: ParseException) {
}
model.eachFunctionExecutionTimeoutMillis = eachFunctionExecutionTimeoutMillisSpinner.number.toLong()
val settings = model.project.service<Settings>()
with(settings) {
model.eachFunctionExecutionTimeoutMillis = hangingTestsTimeout.timeoutMs
}
model.allFunctionExecutionTimeoutMillis =
TimeUnit.SECONDS.toMillis(allFunctionExecutionTimeoutSecondsSpinner.number.toLong())
super.doOKAction()
Expand Down