Skip to content

Support Spring guided type replacements in symbolic engine #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 15, 2023

Conversation

EgorkaKulikov
Copy link
Collaborator

Description

We will have some knowledge about concrete types implementing interfaces from utbot-spring-analyzer
This knowledge guides our Traverser to avoid mocking interfaces and use implementers.

How to test

Automated tests

Definitely need to be written later!

Manual tests

Should not be tested manually as a separate feature.
Test is as a part of Spring support 1st iteration full cycle.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@EgorkaKulikov EgorkaKulikov added ctg-enhancement New feature, improvement or change request comp-symbolic-engine Issue is related to the symbolic execution engine comp-spring Issue is related to Spring projects support labels Mar 7, 2023
@EgorkaKulikov EgorkaKulikov force-pushed the egor/spring_beans_in_engine branch from 96336a9 to 94d4295 Compare March 13, 2023 09:54
@EgorkaKulikov EgorkaKulikov marked this pull request as ready for review March 13, 2023 15:52
Copy link
Member

@Damtev Damtev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some potentially dangerous cases

@EgorkaKulikov EgorkaKulikov force-pushed the egor/spring_beans_in_engine branch from a381bd0 to c495744 Compare March 14, 2023 12:28
Copy link
Member

@Damtev Damtev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM, but I suggest to @CaelmBleidd to take a look

Copy link
Member

@CaelmBleidd CaelmBleidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@EgorkaKulikov EgorkaKulikov force-pushed the egor/spring_beans_in_engine branch from 01b060d to 2c82235 Compare March 15, 2023 13:11
@EgorkaKulikov EgorkaKulikov enabled auto-merge (squash) March 15, 2023 13:14
@EgorkaKulikov EgorkaKulikov merged commit eb6de3c into main Mar 15, 2023
@EgorkaKulikov EgorkaKulikov deleted the egor/spring_beans_in_engine branch March 15, 2023 13:34
@alisevych alisevych added this to the Spring Phase 1 milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-spring Issue is related to Spring projects support comp-symbolic-engine Issue is related to the symbolic execution engine ctg-enhancement New feature, improvement or change request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants