-
Notifications
You must be signed in to change notification settings - Fork 46
Support Spring guided type replacements in symbolic engine #1908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
96336a9
to
94d4295
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some potentially dangerous cases
a381bd0
to
c495744
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM, but I suggest to @CaelmBleidd to take a look
utbot-framework-api/src/main/kotlin/org/utbot/framework/plugin/api/Api.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
01b060d
to
2c82235
Compare
Description
We will have some knowledge about concrete types implementing interfaces from
utbot-spring-analyzer
This knowledge guides our
Traverser
to avoid mocking interfaces and use implementers.How to test
Automated tests
Definitely need to be written later!
Manual tests
Should not be tested manually as a separate feature.
Test is as a part of Spring support 1st iteration full cycle.
Self-check list