Skip to content

Refactoring the npm installation process for JavaScript #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 6, 2023

Conversation

rudolf101
Copy link
Member

Description

The process of checking and installing npm packages has received a number of enhancements:

  • Optimized the process of checking npm packages, now it takes about 2 seconds to check all packages, instead of 5-6 earlier
  • Added a notification to the user about problems with the Internet connection when the timeout expires during the installation of npm packages ("Requirement installation error" title changed to "Failed to install requirements"):

image

Fixes #1829
Fixes #1882

How to test

Manual tests

Various scenarios have been tested. You can find the examples in the folder `/utbot-js/samples' and try to run UTBot.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@rudolf101 rudolf101 added comp-ui Improvements of plugin UI appearence and functionality comp-infrastructure Infrastructure issues lang-javascript Issue is related to JavaScript support ctg-bug-fix PR is fixing a bug labels Mar 3, 2023
@rudolf101 rudolf101 self-assigned this Mar 3, 2023
@rudolf101 rudolf101 merged commit 5db82b4 into main Mar 6, 2023
@rudolf101 rudolf101 deleted the vladislav/npm-packages-installation-refactoring branch March 6, 2023 11:56
@alisevych alisevych added this to the 2023.03 Release milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-infrastructure Infrastructure issues comp-ui Improvements of plugin UI appearence and functionality ctg-bug-fix PR is fixing a bug lang-javascript Issue is related to JavaScript support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS. TimeoutException from JsDialogProcessorKt.installMissingRequirement JavaScript. Dependencies are verified for seconds each time action is called
3 participants