Use deep equality for mock results #1885
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a returned value in the method under test is mocked, we cannot use
assertEquals
because theequals
method for mocks works differently. So, we need to use deep equality in such cases.Fixes #1877.
How to test
Automated tests
Common pipeline.
Manual tests
The same as in the corresponding issue.
Generated test:
As can be seen, deep equality is used here.
Self-check list