Skip to content

Refactoring of JavaScript dialog window #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 28, 2023
Merged

Conversation

rudolf101
Copy link
Member

Description

The JavaScript dialog window has received a number of improvements:

  • Replaced coverage buttons with RadioButton, now you can initially see which mode is selected
  • Removed redundant inscription in the timeout selection field
  • Replaced the “OK” button with “Generate Tests”
  • Removed unnecessary gaps
  • Improved the description of the tooltip for coverage buttons

Now the dialog window looks like this:

image

Fixes #1671

How to test

Manual tests

Various scenarios have been tested. You can find the examples in the folder `/utbot-js/samples' and try to run UTBot.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@rudolf101 rudolf101 added ctg-enhancement New feature, improvement or change request comp-ui Improvements of plugin UI appearence and functionality lang-javascript Issue is related to JavaScript support labels Feb 27, 2023
@rudolf101 rudolf101 self-assigned this Feb 27, 2023
@rudolf101 rudolf101 requested a review from Markoutte February 27, 2023 14:13
@rudolf101 rudolf101 enabled auto-merge (squash) February 27, 2023 14:22
@rudolf101 rudolf101 merged commit cf1f74f into main Feb 28, 2023
@rudolf101 rudolf101 deleted the vladislav/js-ui-update branch February 28, 2023 04:16
@alisevych alisevych added this to the 2023.03 Release milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-ui Improvements of plugin UI appearence and functionality ctg-enhancement New feature, improvement or change request lang-javascript Issue is related to JavaScript support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad formatting & info in JavaScript plugin window
3 participants