Skip to content

Assemble constModel in UtArrayModel if required #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

EgorkaKulikov
Copy link
Collaborator

@EgorkaKulikov EgorkaKulikov commented Feb 14, 2023

Description

The logic of AssembleModelGenerator is designed to traverse all models recursively and try to assemble them.

UtArrayModel has constModel field, but it is not involved in instance creation if all elements are set with stores. We should not assemble constModel in such case.

How to test

Automated tests

  • The set of AssembleModelGeneratorTests
  • Tests in arrays package of utbot-samples

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@EgorkaKulikov EgorkaKulikov added comp-symbolic-engine Issue is related to the symbolic execution engine ctg-bug-fix PR is fixing a bug labels Feb 14, 2023
@EgorkaKulikov EgorkaKulikov requested a review from Damtev February 14, 2023 16:00
@EgorkaKulikov EgorkaKulikov enabled auto-merge (squash) February 14, 2023 16:09
@EgorkaKulikov EgorkaKulikov merged commit a4a83f6 into main Feb 14, 2023
@EgorkaKulikov EgorkaKulikov deleted the egor/asmodgen_arrays_constmodel branch February 14, 2023 16:11
@alisevych alisevych added this to the 2023.03 Release milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-symbolic-engine Issue is related to the symbolic execution engine ctg-bug-fix PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants