Skip to content

Implement properly streams closure after running cmd in JavaScript #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 3, 2023
Merged

Implement properly streams closure after running cmd in JavaScript #1768

merged 4 commits into from
Feb 3, 2023

Conversation

rudolf101
Copy link
Member

Description

After running cmd execution for JS, the received inputStream and errorStream are closed properly.

Fixes #1591

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually

Checklist:

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • No new warnings
  • All tests pass locally with my changes

@rudolf101 rudolf101 added lang-javascript Issue is related to JavaScript support ctg-bug-fix PR is fixing a bug labels Feb 3, 2023
@rudolf101 rudolf101 requested a review from Markoutte February 3, 2023 09:50
@rudolf101 rudolf101 self-assigned this Feb 3, 2023
@rudolf101 rudolf101 merged commit a7fb7ad into main Feb 3, 2023
@rudolf101 rudolf101 deleted the vladislav/js-cmd-execution-ref branch February 3, 2023 11:56
tamarinvs19 pushed a commit that referenced this pull request Feb 6, 2023
@rudolf101 @tamarinvs19
Implement properly streams closure after running cmd in JavaScript (#…
9cfd36d 
…1768)

* Implemented properly streams closure for JsCmdExec

* Fix after update

* Update logger info about output absolute path

* Add logger for coverage report generation
@alisevych alisevych added this to the 2023.03 Release milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgorkaKulikov EgorkaKulikov EgorkaKulikov approved these changes

@Markoutte Markoutte Awaiting requested review from Markoutte

Assignees

@rudolf101 rudolf101

Labels
ctg-bug-fix PR is fixing a bug lang-javascript Issue is related to JavaScript support
Projects
None yet
Milestone
2023.3 Release
Development

Successfully merging this pull request may close these issues.

Proper streams closure after running cmd in JavaScript
3 participants
@rudolf101 @EgorkaKulikov @alisevych