Skip to content

Move all summary tests in utbot-summary-tests project #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 2, 2023

Conversation

sofurihafe
Copy link
Member

@sofurihafe sofurihafe commented Feb 1, 2023

Description

This PR removes all checks related to summaries from engine checks (UtValueTestCaseChecker).
Now, all summary tests are located in utbot-summary-tests project as separate tests.

This approach was recommended by Alexey Zinoviev: he claims that tests in summary module are designed better, they are more "integrative". Duplicated checks are removed from engine test suite, some new summaries tests were introduced.

Fixes # (382)

How to test

Automated tests

All tests for utbot-summary module

Manual tests

Not required: changes are related to tests projects only.

@sofurihafe sofurihafe force-pushed the andrey-t/summary_module_refactoring branch from 07f4a50 to 4d083fa Compare February 1, 2023 14:56
@sofurihafe sofurihafe added ctg-refactoring Issue related to refactoring process comp-summaries Something related to the method names, code comments and display names generation labels Feb 1, 2023
@sofurihafe sofurihafe changed the title Move all summary tests in utbot-summries project Move all summary tests in utbot-summary-tests project Feb 1, 2023
@sofurihafe sofurihafe marked this pull request as ready for review February 1, 2023 15:13
@sofurihafe sofurihafe merged commit 2a446d6 into main Feb 2, 2023
@sofurihafe sofurihafe deleted the andrey-t/summary_module_refactoring branch February 2, 2023 10:38
tamarinvs19 pushed a commit that referenced this pull request Feb 6, 2023
* Remove duplicate summary tests from engine checks

* Move summary tests from engine checks to separate summary tests

* Remove summary checks from engine checks
@alisevych alisevych added this to the 2023.03 Release milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-summaries Something related to the method names, code comments and display names generation ctg-refactoring Issue related to refactoring process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AbstractTestCaseGeneratorTest.kt and SummaryTestCaseGeneratorTest.kt contains duplicated methods
3 participants