Skip to content

Add constraints to the start line field in SARIF #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 1, 2023

Conversation

mmvpm
Copy link
Collaborator

@mmvpm mmvpm commented Jan 31, 2023

Description

Made sure that startLine field in the SarifRegion is greater than zero after calling the SarifRegion.withStartLine method.

Fixes #1759

How to test

Automated tests

Regression: org.utbot.sarif.SarifReportTest

Manual tests

Please, repeat the scenario from the issue #1759

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@mmvpm mmvpm added comp-sarif Issue is related to SARIF report or Problems tab ctg-bug-fix PR is fixing a bug labels Jan 31, 2023
@mmvpm mmvpm self-assigned this Jan 31, 2023
@mmvpm
Copy link
Collaborator Author

mmvpm commented Jan 31, 2023

Log file in the %TEMP%/UTBot/rdEngineProcessLogs

@mmvpm mmvpm requested a review from alisevych February 1, 2023 08:49
@alisevych
Copy link
Member

The issue #1759 is :

  • reproducing with plugin built from main
  • NOT reproducing with plugin built from this branch.
    The fix is thus verified.

@mmvpm mmvpm merged commit 5052979 into main Feb 1, 2023
@mmvpm mmvpm deleted the ideaseeker/inspection_tool_iobe_minus_one branch February 1, 2023 12:32
@alisevych alisevych added this to the 2023.03 Release milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-sarif Issue is related to SARIF report or Problems tab ctg-bug-fix PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexOutOfBoundsException: Wrong line: -1. from Inspection tool on found problem
2 participants