Skip to content

Add minor hints to PR template #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Conversation

olganaumenko
Copy link
Collaborator

Description

Supplemented the PR template with minor hints according to requests from the team.

How to test

Manual tests

The PR introduces no code changes.
Manual scenario: the text itself has been previewed in the IntelliJ IDEA viewer.

Self-check list

Check off the item if the statement is true:

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@olganaumenko olganaumenko added ctg-documentation Improvements or additions to documentation comp-infrastructure Infrastructure issues labels Jan 25, 2023
- Mention the related issue (_**"Fixes #..."**_) or describe why you've made the changes.
Fixes # (issue)

- If there is no related issue, describe why you've made the changes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

  • If there is no related issue, describe the changes you've made.

Copy link
Member

@alisevych alisevych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@olganaumenko olganaumenko merged commit ec4de3d into main Jan 25, 2023
@olganaumenko olganaumenko deleted the olganaumenko/PR_template_fix branch January 25, 2023 10:03
@alisevych alisevych added this to the 2023.03 Release milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-infrastructure Infrastructure issues ctg-documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants