Skip to content

Redesign for Concrete Executor timeout #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 27, 2023

Conversation

Domonion
Copy link
Collaborator

@Domonion Domonion commented Jan 20, 2023

Redesign for Concrete Executor timeout

Add docs.

Description

Fix #1726

Manual tests

See #1726 for repro - should fix

Additional contest

If docker image for monitoring is not available - CI should continue even without monitoring. Added in github workflow.

Mockito warmup as it takes too much time in tests to initialize it - fixed with warmup at the start of the process.

Providing additional auxiliary log information when running in docker.

@Domonion Domonion added comp-symbolic-engine Issue is related to the symbolic execution engine comp-rd Issue is related RD comp-instrumented-process Issue is related to Instrumented process ctg-bug-fix PR is fixing a bug labels Jan 20, 2023
@Domonion Domonion self-assigned this Jan 20, 2023
@Domonion Domonion force-pushed the kononov-instrumentation-process-timeout branch 3 times, most recently from 14b419b to 26a4530 Compare January 26, 2023 12:03
@Domonion Domonion force-pushed the kononov-instrumentation-process-timeout branch from e7ac3f8 to c7acf0d Compare January 26, 2023 16:23
Copy link
Collaborator Author

@Domonion Domonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Domonion and others added 6 commits January 27, 2023 11:55
1. New timeouts system for contest estimator.
2. Concrete execution phases redesign
Fix #1726
Possible fix #1718
If docker image for monitoring is not available - CI should continue
even without monitoring
Mockito warmup as it takes too much time in tests to initialize it
Providing additional auxiliary log information when running in docker
Review fix
@Domonion Domonion force-pushed the kononov-instrumentation-process-timeout branch from 420ea70 to ba0e82f Compare January 27, 2023 08:56
@Domonion Domonion enabled auto-merge (squash) January 27, 2023 08:56
@Domonion Domonion merged commit eaf4b55 into main Jan 27, 2023
@Domonion Domonion deleted the kononov-instrumentation-process-timeout branch January 27, 2023 09:21
@alisevych alisevych added this to the 2023.03 Release milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-instrumented-process Issue is related to Instrumented process comp-rd Issue is related RD comp-symbolic-engine Issue is related to the symbolic execution engine ctg-bug-fix PR is fixing a bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

UtExecutionInstrumentation does not respect timeout in concrete execution
3 participants