Skip to content

Added CgLanguageAssistant to CodeGeneration constructor #1639 #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2023
Merged

Added CgLanguageAssistant to CodeGeneration constructor #1639 #1640

merged 1 commit into from
Jan 9, 2023

Conversation

tamarinvs19
Copy link
Collaborator

@tamarinvs19 tamarinvs19 commented Jan 9, 2023 •
edited
Loading

Description

I moved argument cgLanguageAssistant to the constructor of CodeGenerator and removed the double initialization of the field context. Now in PythonCodeGenerator we have only CgPythonLanguage and Java/Kotlin else.

Fixes #1639

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Manual Scenario

See #1639

Checklist (remove irrelevant options):

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

@tamarinvs19 tamarinvs19 added comp-codegen Issue is related to code generator lang-python Issue is related to python support labels Jan 9, 2023
@tamarinvs19 tamarinvs19 merged commit 7922e63 into main Jan 9, 2023
@tamarinvs19 tamarinvs19 deleted the tamarinvs19/change_code_generator_constructor branch January 9, 2023 13:18
@alisevych alisevych added the ctg-enhancement New feature, improvement or change request label Jan 23, 2023
@alisevych alisevych added this to the 2023.03 Release milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgorkaKulikov EgorkaKulikov EgorkaKulikov approved these changes

@denis-fokin denis-fokin Awaiting requested review from denis-fokin

Assignees
No one assigned
Labels
comp-codegen Issue is related to code generator ctg-enhancement New feature, improvement or change request lang-python Issue is related to python support
Projects
None yet
Milestone
2023.3 Release
Development

Successfully merging this pull request may close these issues.

Python test generation failed in PythonCodeGenerator initialization
3 participants
@tamarinvs19 @EgorkaKulikov @alisevych