New treating of artificial errors #1573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorkaKulikov
changed the title
EgorkaKulikov
force-pushed
the
egor/simple_overflow
branch
from
ff026fe to
132cecd
Compare
EgorkaKulikov
force-pushed
the
egor/simple_overflow
branch
from
dc15353 to
2ae6d89
Compare
Damtev
requested changes
Dec 23, 2022
utbot-framework/src/main/kotlin/org/utbot/framework/codegen/tree/CgMethodConstructor.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/codegen/tree/CgMethodConstructor.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/codegen/tree/CgMethodConstructor.kt
Outdated
Show resolved
Hide resolved
EgorkaKulikov
force-pushed
the
egor/simple_overflow
branch
from
2ae6d89 to
a34e7fc
Compare
EgorkaKulikov
force-pushed
the
egor/simple_overflow
branch
from
fd02764 to
d1c47e5
Compare
Damtev
approved these changes
Dec 23, 2022
tamarinvs19
pushed a commit
that referenced
this pull request
Jan 9, 2023
alisevych
added
ctg-enhancement
zishkaz
pushed a commit
that referenced
this pull request
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently generated unit tests for OverflowExamples from utbot-samples are false negatives if the mode to treat overflows as errors is selected.
The only sign of something wrong is a comment about failing test. Test passes whenever it's behavior is unpredictable.
We should add failing assertion and show that actual result is not reliable. It requires changes in
Everything except summarization is ready now.
Fixes # (1272)
Type of Change
How Has This Been Tested?
Regression and integration tests
OverflowAsErrorTestas far as no new scenarios were added to the symbolic engine, we just corrected current tests
Manual Scenario
Stanfard checks on both codegen languages and used test frameworks that generated code with failure assertion is compilable and test run results correlate with our expectations.