Skip to content

Change unsafe access to jClass in updateGenericTypeInfo #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

CaelmBleidd
Copy link
Member

@CaelmBleidd CaelmBleidd commented Dec 15, 2022

Description

In org.utbot.engine.Traverser#updateGenericTypeInfo we access executable for the method under test. It goes into jClass and extracts a method instance from it, which may cause an error if we don't have this class in the classpath. Since this function is not mandatory for analysis, we can just not update generic info and continue analysis instead of falling.

Type of Change

Please delete options that are not relevant.

  • Minor bug fix (non-breaking small changes)

How Has This Been Tested?

Regression and integration tests

There are no additional tests since they highly depend on classpath, project configuration, soot transformation and other options. Unfortunately, the exact combination of these options is lost and the problem occurred on a project with closed code.

Automated Testing

There are no additional automatic tests.

Manual Scenario

There are no manual scenarios.

Checklist:

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • All tests pass locally with my changes

@CaelmBleidd CaelmBleidd requested a review from Damtev December 15, 2022 09:57
@CaelmBleidd CaelmBleidd requested a review from Damtev December 15, 2022 10:08
@CaelmBleidd CaelmBleidd force-pushed the caelmbleidd/run_catching_for_update_parameterized_type branch from 17ec0db to 55a7420 Compare December 15, 2022 10:10
@CaelmBleidd CaelmBleidd enabled auto-merge (squash) December 15, 2022 10:21
@CaelmBleidd CaelmBleidd disabled auto-merge December 15, 2022 10:22
@CaelmBleidd CaelmBleidd enabled auto-merge (squash) December 15, 2022 10:22
@CaelmBleidd CaelmBleidd merged commit 82a38d3 into main Dec 15, 2022
@CaelmBleidd CaelmBleidd deleted the caelmbleidd/run_catching_for_update_parameterized_type branch December 15, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants