Skip to content

Add disjunction with null condition to isMock constraint #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

CaelmBleidd
Copy link
Member

@CaelmBleidd CaelmBleidd commented Dec 15, 2022

Description

Added a disjunction with nullability constraint to avoid an assignment to a null object contradicting conditions about whether it is mock or not.

Fixes #1520

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Regression and integration tests

There is no difference between automatic tests and international tests for the engine.

Automated Testing

org.utbot.examples.mock.CommonMocksExample#mocksForNullOfDifferentTypes

Manual Scenario

Did not check it manually.

Checklist:

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

@CaelmBleidd CaelmBleidd force-pushed the caelmbleidd/null_values_as_mock_fix branch from 55e5eec to fda8e9f Compare December 15, 2022 06:03
Copy link
Member

@sergeypospelov sergeypospelov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaelmBleidd CaelmBleidd merged commit e28e14c into main Dec 15, 2022
@CaelmBleidd CaelmBleidd deleted the caelmbleidd/null_values_as_mock_fix branch December 15, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mock label is assigned to null values
2 participants