Make symbolic execs preferable in minimization process #1514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ork-test/src/test/kotlin/org/utbot/framework/minimization/MinimizationGreedyEssentialTest.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/minimization/Minimization.kt
Outdated
Show resolved
Hide resolved
sofurihafe
force-pushed
the
andrey-t/symbolic-execs-supremacy
branch
from
6ed1e6c to
37662b4
Compare
sofurihafe
force-pushed
the
andrey-t/symbolic-execs-supremacy
branch
from
37662b4 to
02fe06a
Compare
EgorkaKulikov
approved these changes
Dec 14, 2022
Why? I remember the last discussion of it with Dmitry Timofeev and @sergeypospelov, and they were against this solution because of many reasons. As for me, the most important ones were described by Dmitry in his first attempt. I don't see any of the persons responsible for the minimization part or people who discussed it back then here in reviewers or in the issue discussion, so, the obvious question -- was has changed since that that moment, and what are the answers on Dmitry's (and mine, since we discussed it with him as well) concerns? |
tamarinvs19
pushed a commit
that referenced
this pull request
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After some discussions it was decided to prioritize symbolic executions over fuzzed ones. Now, priority is based on source priority (symbolic is preferable), number of useful lines (more is preferable), and exec id.
For instance, if there are two identical executions differing only by their source, the one from symbolic engine will be preferable in minimization.
This is the second attempt of pull854.
Fixes # (1504)
Type of Change
How Has This Been Tested?
Regression and integration tests
Added a new test testPriority1 in MinimizationGreedyEssentialTest.
Automated Testing
utbot-samples, plus testPriorityTest1.
Manual Scenario
Generate a test for max method in IntExamples sample. Verify that there are two tests sourcing from symbolic engine in the generated test.