Make dependency on maven plugin optional #1513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vassiliy-Kudryashov
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To add dependencies into Maven projects, we have custom version of MavenProjectModelModifier, because original one contains bugs.
This functionality requires the dependency on
org.jetbrains.idea.maven.Adding it makes our plugin incompatible with PyCharm and WebStorm. Thus we need to make it optional.
Partially fixes # (1468)
Type of Change
How Has This Been Tested?
Regression and integration tests
Verify that dependencies are still installed correctly in all Maven projects: for example, check TestNg on projects with JDK8 and JDK11, versions 7.5 and 7.6.* should be installed.
Manual Scenario
Possibly verify on PyCharm, but currently it can't be dun via runIde service because of the dependencies on java not supported in PyCharm. We can only create a plugin build and install it into Intellij Idea manually.