some options moved from gradle.properties to GRADLE_OPTS #1470 #1472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-fokin
reviewed
Dec 7, 2022
denis-fokin
reviewed
Dec 7, 2022
gradle.properties
Outdated
| org.gradle.jvmargs="-XX:MaxHeapSize=6144m" | ||
| kotlin.compiler.execution.strategy=in-process | ||
| org.gradle.caching=false | ||
|
|
||
| # configuration for local compilation - much faster | ||
| #org.gradle.daemon=true |
There was a problem hiding this comment.
Can we enable the properties and overload them as Gradle environment options?
There was a problem hiding this comment.
GRADLE_OPTS environment variable has lower priority than gradle.properties file
There was a problem hiding this comment.
Maybe we should use GRADLE_OPTS here if they present?
…egor-vasiliev/1470-move-gradle-properties
…egor-vasiliev/1470-move-gradle-properties
…egor-vasiliev/1470-move-gradle-properties
…egor-vasiliev/1470-move-gradle-properties
gradle.properties
Outdated
| # overrided by some parameters in CI, read below about each option |
There was a problem hiding this comment.
"Overriden", not "overrided"
…egor-vasiliev/1470-move-gradle-properties
…egor-vasiliev/1470-move-gradle-properties
…egor-vasiliev/1470-move-gradle-properties
denis-fokin
approved these changes
Jan 23, 2023
…egor-vasiliev/1470-move-gradle-properties
alisevych
added
comp-infrastructure
…egor-vasiliev/1470-move-gradle-properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
org.gradle.daemon=false- moved toGRADLE_OPTSbut this option is not needed because we explicitly run gradle with--no-daemonoption. Should I remove--no-daemonor leave it as is?org.gradle.parallel=false- moved toGRADLE_OPTSkotlin.compiler.execution.strategy=in-process- moved toGRADLE_OPTSorg.gradle.caching=false- removed completely because we don't have caches on runners by default. To obtain cache we should useactions/cache@v3and in those cases we explicitly run gradle with--build-cacheoptionFixes #1470
Type of Change
How Has This Been Tested?
Regression and integration tests
No tests needed
Automated Testing
Run workflow from a branch
Manual Scenario
Not applicable
Checklist (remove irrelevant options):