Generation shouldn't fail if there is old (not actually locked) utbot… #1350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Markoutte
approved these changes
Nov 11, 2022
Vassiliy-Kudryashov
deleted the
Vassiliy-Kudryashov/fix_for_existing_lock_file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
….lock file
Description
Existing but not locked utbot.lock shouldn't prevent generation to start.
Type of Change
How Has This Been Tested?
Manual Scenario
Expected behavior: Generation starts, file will be re-written with currrent timestamp inside.
Observed behavior: Generation fails as the file cannot be open to write with StandardOpenOption.CREATE_NEW for existing file.
Checklist (remove irrelevant options):