Treat Kotlin getters/setters as KnownImplicitlyDeclaredMethods #1338 #1339 #1341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/contest estimator
volivan239
force-pushed
the
volivan239/fxing_kotlin_cli
branch
from
fba45a1 to
336e03e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added filtering of Kotlin autogenerated getters/setters to
ExecutableId.isKnownImplicitlyDeclaredMethod. Also added some checks to prevent using Kotlin reflection on facade classes -- see KT-16479Fixes #1338, #1339
Type of Change
How Has This Been Tested?
Manual Scenario
Launched cli on examples from #1338 and #1339 -- works as expected
Checklist (remove irrelevant options):