Skip to content

Move test-specific implementation #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 14, 2022

Conversation

denis-fokin
Copy link
Collaborator

@denis-fokin denis-fokin commented Nov 8, 2022

Description

I have moved test-specific code in a separate Gradle module. Now this code could be referenced individually by different parts of our implementation (summaries/framework tests)

Fixes #1349

Type of Change

Please delete options that are not relevant.

  • Refactoring (typos and non-functional changes)

How Has This Been Tested?

Automated Testing

Local and remote automatic test have passed.

Manual Scenario

No specific scenarios.

Checklist (remove irrelevant options):

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

@denis-fokin denis-fokin marked this pull request as draft November 8, 2022 12:55
@denis-fokin denis-fokin force-pushed the denis-fokin/move-test-specific-implementation branch from dc602ce to 6e5cd0e Compare November 9, 2022 08:28
@denis-fokin denis-fokin force-pushed the denis-fokin/move-test-specific-implementation branch from a11592f to 0cf6238 Compare November 10, 2022 14:21
@denis-fokin denis-fokin marked this pull request as ready for review November 10, 2022 14:50
@denis-fokin denis-fokin enabled auto-merge (squash) November 10, 2022 14:51
@denis-fokin denis-fokin requested a review from Damtev November 10, 2022 14:51
Copy link
Member

@Damtev Damtev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor issues, mostly about redundant empty lines

Comment on lines 6 to 7


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Comment on lines 3 to 4


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@@ -4,9 +4,10 @@ import examples.CustomJavaDocTagsEnabler
import examples.SummaryTestCaseGeneratorTest
import org.junit.jupiter.api.Test
import org.junit.jupiter.api.extension.ExtendWith
import org.utbot.tests.infrastructure.DoNotCalculate

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@@ -2,9 +2,10 @@ package examples.ternary

import examples.SummaryTestCaseGeneratorTest
import org.junit.jupiter.api.Test
import org.utbot.tests.infrastructure.DoNotCalculate

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@@ -3,9 +3,10 @@ package math
import examples.SummaryTestCaseGeneratorTest
import guava.examples.math.IntMath
import org.junit.jupiter.api.Test
import org.utbot.tests.infrastructure.DoNotCalculate

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@@ -4,9 +4,10 @@ import examples.SummaryTestCaseGeneratorTest
import guava.examples.math.Stats
import org.junit.jupiter.api.Disabled
import org.junit.jupiter.api.Test
import org.utbot.tests.infrastructure.DoNotCalculate

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@@ -17,4 +17,5 @@ dependencies {
implementation("com.github.javaparser:javaparser-core:3.22.1")
testImplementation("org.mockito:mockito-core:4.2.0")
testImplementation("org.junit.jupiter:junit-jupiter:$junit5Version")
testImplementation(project(":utbot-testing"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it required? As I see, utbot-summary-tests module already has such dependency

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very true, thank you

@denis-fokin denis-fokin merged commit 95623c0 into main Nov 14, 2022
@denis-fokin denis-fokin deleted the denis-fokin/move-test-specific-implementation branch November 14, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move test-specific code fromthe framework
2 participants