Stabilize the behavior of ConstructorAnalyzer

[volivan239]

Description

Removed vistiedConstructors from ConstructorAnalyzer.analyze() method. The intention of that container was to prevent from infinite recursion and to increase performance when analyzing chain of constructors. However, it lead to possible errors if the outer method was called more then once. Also, infinite recursion isn't actually possible since recursive constructor calls are forbidden both in Java and Kotlin. Performance changes seems to be miserable.

Type of Change

• Minor bug fix (non-breaking small changes)

How Has This Been Tested?

Manual Scenario

Tested on the following class -- previously incorrect behavior of ConstructAnalyzer lead to unnecessary reflection used for expected models, after these changes no reflection is used.

class NullabilityIssuesExample(val x: Int) {
    fun copyWithX(new_x: Int?): NullabilityIssuesExample? {
        if (new_x == null)
            return null
        return NullabilityIssuesExample(x + new_x)
    }
}

Checklist (remove irrelevant options):

This is the author self-check list

• The change followed the style guidelines of the UTBot project
• Self-review of the code is passed
• The change contains enough commentaries, particularly in hard-to-understand areas
• New documentation is provided or existed one is altered
• No new warnings
• New tests have been added
• All tests pass locally with my changes

[volivan239]

Doesn't work and needs smarter approach -- see #1353