Skip to content

Construct assemble models for classes with val-properties in constructor #1190 #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

volivan239
Copy link
Collaborator

Description

Modified assembleCompositeModel(UtCompositeModel) so that if final fields exist but they all are set by constructor, then we still try to create assemble model (before PR, any final field meant that model can't be assembled).

Fixes #1190

Type of Change

  • Minor bug fix (non-breaking small changes)

How Has This Been Tested?

Manual Scenario

Tested on scenario from #1190 -- works as expected.

Checklist (remove irrelevant options):

This is the author self-check list

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

@volivan239 volivan239 marked this pull request as ready for review October 26, 2022 16:53
@volivan239 volivan239 force-pushed the volivan239/fixing_unnecessary_reflection_in_kotlin_constructors branch from e106126 to d5728f6 Compare October 31, 2022 10:05
@volivan239 volivan239 force-pushed the volivan239/fixing_unnecessary_reflection_in_kotlin_constructors branch from d5728f6 to 96587bd Compare October 31, 2022 10:06
@volivan239 volivan239 merged commit 15d2b4f into main Oct 31, 2022
@volivan239 volivan239 deleted the volivan239/fixing_unnecessary_reflection_in_kotlin_constructors branch October 31, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary reflection used for val properties that can be set via constructor
2 participants