Skip to content

Plugin Action stays locked even when previous generation is finished … #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Vassiliy-Kudryashov
Copy link
Member

#1173

Description

"unlock" calling was put in a wrong place, actually locking process should correspond to "try-finally" concept

Fixes #1173

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual Scenario

See the issue, lock should be removed after tests generation

Checklist (remove irrelevant options):

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • No new warnings

Copy link
Collaborator

@Markoutte Markoutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider to use java.nio.channels.FileLock in the future. Looks like it works at the moment

@Vassiliy-Kudryashov Vassiliy-Kudryashov enabled auto-merge (squash) October 18, 2022 13:56
@Vassiliy-Kudryashov Vassiliy-Kudryashov merged commit 88f83c0 into main Oct 18, 2022
@Vassiliy-Kudryashov Vassiliy-Kudryashov deleted the Vassiliy-Kudryashov/1173-plugin-action-stays-locked-even-when-previous-generation-is-finished branch October 18, 2022 14:21
@alisevych alisevych mentioned this pull request Oct 19, 2022
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin Action stays locked even when previous generation is finished
2 participants